Fix failing T12010
ClosedPublic

Authored by Phyx on May 21 2016, 9:39 AM.

Details

Summary

T12010 seems to be failing because it can't find the correct paths.
This gives the test some more qualified paths.

Test Plan

make TEST=12010

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Phyx retitled this revision from to Fix failing T12010.May 21 2016, 9:39 AM
Phyx updated this object.
Phyx edited the test plan for this revision. (Show Details)
Phyx added a reviewer: thomie.
Phyx updated the Trac tickets for this revision.
Phyx added a comment.May 21 2016, 10:01 AM

Not really sure why I need to qualify the paths like that.

Is this the correct way to do this @thomie ?

austin accepted this revision.May 21 2016, 11:34 AM
This revision is now accepted and ready to land.May 21 2016, 11:34 AM

This unbreaks harbormaster, so feel free to land it.

But tests shouldn't include files from the source directory. In in a freshly cloned ghc repository, running make test TEST=T12010 TEST_HC=ghc still fails, because HsBaseConfig.h isn't available.

Also, a "proper" fix would use extra_files(['cbits/']) instead of qualifying those paths.

Phyx added a comment.May 21 2016, 11:45 AM

But tests shouldn't include files from the source directory. In in a freshly cloned ghc repository, running make test TEST=T12010 TEST_HC=ghc still fails, because HsBaseConfig.h isn't available.

Also, a "proper" fix would use extra_files(['cbits/']) instead of qualifying those paths.

Ah thanks, I'm just heading out the door now, so I'll land this one and fix it properly when I come back.

This revision was automatically updated to reflect the committed changes.
enolan added a subscriber: enolan.May 21 2016, 1:04 PM

I'm confused, does the test runner not always cd into the directory with the .T file?

In D2252#65045, @enolan wrote:

I'm confused, does the test runner not always cd into the directory with the .T file?

I changed it recently to run tests in a /tmp directory. See https://mail.haskell.org/pipermail/ghc-devs/2016-May/012082.html. I expected some confusion during the transition period, and this test was the first to be hit by it.

See D2256 for my attempt for a fix.