rts: More const correct-ness fixes
ClosedPublic

Authored by erikd on May 17 2016, 6:13 AM.

Details

Summary

In addition to more const-correctness fixes this patch fixes an
infelicity of the previous const-correctness patch (995cf0f356) which
left UNTAG_CLOSURE taking a const StgClosure pointer parameter
but returning a non-const pointer. Here we restore the original type
signature of UNTAG_CLOSURE and add a new function
UNTAG_CONST_CLOSURE which takes and returns a const StgClosure
pointer and uses that wherever possible.

Test Plan

Validate on Linux, OS X and Windows

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
erikd updated this revision to Diff 7623.May 17 2016, 6:13 AM
erikd retitled this revision from to rts: More const correct-ness fixes.
erikd updated this object.
erikd edited the test plan for this revision. (Show Details)
erikd added reviewers: trofi, simonmar, Phyx, hsyl20.
erikd edited the test plan for this revision. (Show Details)May 17 2016, 6:29 AM
erikd edited edge metadata.
simonmar accepted this revision.May 17 2016, 6:32 AM
simonmar edited edge metadata.

Looks good, thanks @erikd

This revision is now accepted and ready to land.May 17 2016, 6:32 AM
trofi accepted this revision.May 17 2016, 2:02 PM
trofi edited edge metadata.
Phyx accepted this revision.May 17 2016, 4:03 PM
Phyx edited edge metadata.
Phyx added inline comments.
rts/Hash.h
25

Should data here also not be const?

This revision was automatically updated to reflect the committed changes.