We also need to retypecheck before when we do parallel make.
ClosedPublic

Authored by ezyang on May 15 2016, 7:03 PM.

Details

Summary

Kept this seperate from the previous patch for clarity.
Comes with a test.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Test Plan

validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ezyang updated this revision to Diff 7589.May 15 2016, 7:03 PM
ezyang retitled this revision from to We also need to retypecheck before when we do parallel make..
ezyang updated this object.
ezyang edited the test plan for this revision. (Show Details)
ezyang added a reviewer: simonpj.
ezyang updated the Trac tickets for this revision.
ezyang updated this revision to Diff 7592.May 15 2016, 7:06 PM
ezyang edited edge metadata.

add missing stderr file

bgamari resigned from this revision.May 24 2016, 4:58 AM
bgamari removed a reviewer: bgamari.

I'm afraid I really can't comment on the correctness of this but otherwise it looks fine to me.

thomie added inline comments.May 24 2016, 5:12 AM
testsuite/tests/typecheck/should_fail/all.T
423

Replace the extra_clean(..) by extra_files(['T12035.hs', 'T12035a.hs']), and (optionally) drop the -outputdir.

bgamari requested changes to this revision.May 30 2016, 3:28 AM
bgamari added a reviewer: bgamari.
bgamari added a subscriber: bgamari.

D2213 needs revision, therefore this does as well by transitivity.

This revision now requires changes to proceed.May 30 2016, 3:28 AM
This revision was automatically updated to reflect the committed changes.