Retypecheck both before and after finishing hs-boot loops in --make.
ClosedPublic

Authored by ezyang on May 13 2016, 2:25 AM.

Details

Summary

This makes ghc --make's retypecheck behavior more in line
with ghc -c, which is able to tie the knot as we are typechecking.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Test Plan

validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ezyang retitled this revision from to Retypecheck both before and after finishing hs-boot loops in --make..May 13 2016, 2:25 AM
ezyang updated this object.
ezyang edited the test plan for this revision. (Show Details)
ezyang added a reviewer: simonpj.
ezyang updated the Trac tickets for this revision.

At the moment, this causes a few tests to fail. The two blockers are https://ghc.haskell.org/trac/ghc/ticket/12064#ticket and https://phabricator.haskell.org/D2215

I think we decided that we need to retypecheck BEFORE but not AFTER

bgamari requested changes to this revision.May 24 2016, 4:00 AM

It seems there is more to be done here; bumping out of review queue.

This revision now requires changes to proceed.May 24 2016, 4:00 AM
This revision was automatically updated to reflect the committed changes.