Add support for unicode TH quotes (#11743)
ClosedPublic

Authored by JoshPrice247 on May 8 2016, 10:51 PM.

Details

Summary

I've also added cases for IToparenbar and ITcparenbar (aka banana
brackets) to isUnicode.

Document unicode TH quote alternatives (Trac #11743)

Test Plan

./validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
JoshPrice247 retitled this revision from to Add support for unicode TH quotes (#11743).May 8 2016, 10:51 PM
JoshPrice247 updated this object.
JoshPrice247 edited the test plan for this revision. (Show Details)
JoshPrice247 updated the Trac tickets for this revision.
austin requested changes to this revision.May 10 2016, 9:03 AM

Great, thanks for finishing this off! Can you just add a simple test? (Or maybe even modify/consolidate with the test from D2012?)

This revision now requires changes to proceed.May 10 2016, 9:03 AM
JoshPrice247 updated this revision to Diff 7528.EditedMay 11 2016, 3:25 PM

Modify tests to include unicode TH quotes

The "arrowsyntax" test has been renamed to "brackets", and now includes
unicode TH brackets.

bgamari accepted this revision.May 12 2016, 4:06 AM

Awesome, this looks great! Thanks again.

@austin: you're blocking this patch at the moment

This revision was automatically updated to reflect the committed changes.