testsuite: fix up T11223's Makefile
ClosedPublic

Authored by austin on Apr 28 2016, 5:18 PM.

Details

Summary

As reported by Simon on ghc-devs, this causes the build on Windows
to fail because it cannot find the cc command. The Makefile here
actually already sets GCC=gcc, but for some reason then uses both
$(GCC) and $(CC) to refer to C compilation.

Signed-off-by: Austin Seipp <austin@well-typed.com>

Test Plan

Cross my fingers

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
austin retitled this revision from to testsuite: fix up T11223's Makefile.Apr 28 2016, 5:18 PM
austin updated this object.
austin edited the test plan for this revision. (Show Details)
austin added reviewers: simonpj, bgamari, hvr, thomie.
austin updated this object.Apr 28 2016, 5:19 PM
thomie accepted this revision.Apr 28 2016, 5:28 PM

Weird.

This revision is now accepted and ready to land.Apr 28 2016, 5:28 PM
In D2158#62644, @thomie wrote:

Weird.

just-makefile-things.jpg

The other mystery is why the hell mingw doesn't come with a CC alias, but that's for another day.

This revision was automatically updated to reflect the committed changes.
Phyx added a subscriber: Phyx.Apr 28 2016, 11:51 PM
In D2158#62652, @austin wrote:

The other mystery is why the hell mingw doesn't come with a CC alias, but that's for another day.

For some reason my mingw does have an alias for CC defined, but it's pointing to cc.exe. Msys has two different kinds of gcc (one msys and one mingw). The msys one comes with far less headers and libraries.

The Windows setup instructions are instructing you to install the wrong one. It's just that the in place gcc takes over. For GHC builds. So the test may still fail, I'll update the instructions later today.

The inconsistency happened because some files compiled using cc while others didn't . So I introduced a new alias gcc to call gcc. But only applied it to those that wouldn't compile.

Thanks for the fix. Just wanted to clarify what happened :)