Fix recomputation of TypeRep in the instance for Typeable (s a) (#9203)
ClosedPublic

Authored by simonmar on Jun 13 2014, 10:58 AM.

Details

Summary

Every time we called typeRep on a type application, we were
recomputing the TypeRep. This showed up in a benchmark I had: Trac #9203.

Test Plan

Benchmark from Trac #9203.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Lint Skipped
Unit
Unit Tests Skipped
simonmar updated this revision to Diff 35.Jun 13 2014, 10:58 AM
simonmar retitled this revision from to Fix recomputation of TypeRep in the instance for Typeable (s a) (#9203).
simonmar updated this object.
simonmar edited the test plan for this revision. (Show Details)
simonmar added reviewers: simonpj, austin.
austin accepted this revision.Jun 13 2014, 5:12 PM
austin edited edge metadata.

applause

This revision is now accepted and ready to land.Jun 13 2014, 5:12 PM
simonmar closed this revision.Jun 16 2014, 7:56 AM
simonmar updated this revision to Diff 37.

Closed by commit rGHC5ffc68bb75d3 (authored by @simonmar).