Fix recomputation of TypeRep in the instance for Typeable (s a) (#9203)
ClosedPublic
Actions

Authored by simonmar on Jun 13 2014, 10:58 AM.

Details

Reviewers

simonpj
austin

Commits

Summary

Every time we called typeRep on a type application, we were
recomputing the TypeRep. This showed up in a benchmark I had: Trac #9203.

Test Plan

Benchmark from Trac #9203.

Repository

rGHC Glasgow Haskell Compiler

Lint

Lint Skipped

Unit

Unit Tests Skipped

simonmar retitled this revision from to Fix recomputation of TypeRep in the instance for Typeable (s a) (#9203).

simonmar updated this object.

simonmar edited the test plan for this revision. (Show Details)

applause

This revision is now accepted and ready to land.Jun 13 2014, 5:12 PM

Closed by commit rGHC5ffc68bb75d3 (authored by @simonmar).

			Path	Packages
M			libraries/base/Data/Typeable/Internal.hs (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	35	c025817		Jun 13 2014, 10:58 AM	★	★
Diff 2	37	0354fb3	Commit rGHC5ffc68bb75d34414987b5d1e5aa4f9061a7a7383	Jun 16 2014, 6:59 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
30226e07c58f	b4c93d331ed4	c0258176ad25	Simon Marlow	Fix recomputation of TypeRep in the instance for Typeable (s a) (#9203) (Show More…)	Jun 13 2014, 10:57 AM