Refactor stack squeezing logic
ClosedPublic

Authored by Tarrasch on Sep 1 2014, 12:28 PM.

Details

Summary

This patch is only to make the code easier to read.

In addition, this is the first patch I send with the arc/differential workflow.
So I start with something very small.

Test Plan

I have not even tried to compile it yet.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Lint Skipped
Unit
Unit Tests Skipped
Tarrasch updated this revision to Diff 469.Sep 1 2014, 12:28 PM
Tarrasch retitled this revision from to Refactor stack squeezing logic.
Tarrasch updated this object.
Tarrasch edited the test plan for this revision. (Show Details)
Tarrasch added reviewers: austin, simonmar.
austin accepted this revision.Sep 1 2014, 12:57 PM
austin edited edge metadata.

LGTM. And don't worry, Phabricator will build your patch for you, so you know it is OK to land.

This revision is now accepted and ready to land.Sep 1 2014, 12:57 PM

Cool! It's awesome that it builds it for me, but the failure I got is not due to me right? It seems like all the 90 builds prior to mine failed as well.

austin added a comment.Sep 1 2014, 1:07 PM

Yes, we've been sloppy. The failures aren't your fault. Hopefully they'll be fixed soon.

Hmm, I tried to land my change but couldn't (I told arc to ignore the build failure). I get this error:

$ arc land
... blah ...
Switched to branch cleanup-stack-squeezing. Identifying and merging...
Landing revision 'D189: Refactor stack squeezing logic'...
Harbormaster failed to build the active diff for this revision. Build failures:

     FAILED  Build 728: GHC Patch Validation (amd64/Linux)

You can review build details here:

    Harbormaster URI: https://phabricator.haskell.org/B726

    Land revision anyway, despite build failures? [y/N] y

Merging cleanup-stack-squeezing into master
Already up-to-date.
Pushing change...

The authenticity of host 'git.haskell.org (88.198.224.241)' can't be established.
ECDSA key fingerprint is 91:4e:95:fa:2e:34:6c:ba:68:af:71:29:ba:66:12:b0.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'git.haskell.org,88.198.224.241' (ECDSA) to the list of known hosts.
Permission denied (publickey).
fatal: The remote end hung up unexpectedly
   PUSH FAILED!   
Switched back to branch cleanup-stack-squeezing.
Usage Exception: 'git push' failed! Fix the error and run 'arc land' again.

In particular

Permission denied (publickey).

Am I supposed to be able to push on my own? Should I upload my public key somewhere? I don't feel that I'm mature enough with ghc working conventions nor code base to be a commiter. Should I let you submit this for me?

austin added a comment.Sep 1 2014, 1:39 PM

Yes, don't worry. You don't have commit access - I'll land this later, you don't have to worry about it.

Perfect, thanks Austin! :)

austin closed this revision.Sep 1 2014, 3:14 PM
austin updated this revision to Diff 483.

Closed by commit rGHC2f343b0cbf8a (authored by @Tarrasch, committed by @austin).