Early error when crosscompiling + haddock/docs
ClosedPublic

Authored by thomie on Feb 3 2016, 11:58 AM.

Details

Summary

When CrossCompiling=YES or Stage1Only=YES, building the haddocks and the
User's Guide should be skipped, because haddock and mkUserGuidePart
depend on the GHC API.
See Note [No stage2 packages when CrossCompiling or Stage1Only] for details.

There are several places in the build system where the variables
HADDOCK_DOCS and BUILD_SPHINX_* are checked. Instead of also checking
for the variables CrossCompiling or Stage1Only in all those places,
make will now exit with a nice error message when the user requests
the impossible.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thomie updated this revision to Diff 6551.Feb 3 2016, 11:58 AM
thomie retitled this revision from to Early error when crosscompiling + haddock/docs.
thomie updated this object.
thomie edited the test plan for this revision. (Show Details)
thomie added a reviewer: rwbarton.
bgamari accepted this revision.Feb 3 2016, 1:04 PM
bgamari edited edge metadata.

Looks good to me although see note inline for a further cleanup.

ghc.mk
712

Oh no! It looks like I neglected to remove BUILD_SPHINX_PS, which isn't used anymore as we don't build Postscript documentation. It looks like the only references are in the build flavor files; cleaning those up would be a nice cleanup.

This revision is now accepted and ready to land.Feb 3 2016, 1:04 PM
thomie updated this revision to Diff 6553.Feb 3 2016, 1:22 PM
thomie edited edge metadata.

Delete BUILD_SPHINX_PS

This revision was automatically updated to reflect the committed changes.