Make TypeError a newtype, add changelog entry
ClosedPublic

Authored by RyanGlScott on Jan 31 2016, 9:14 PM.

Details

Summary

Phab:D866 added the TypeError datatype to Control.Exception to represent
the error that is thrown when -fdefer-type-errors is on, but a changelog
entry for it was never added. In addition, it should probably be a
newtype.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
make-type-error-newtype
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8443
Build 10488: arc lint + arc unit
RyanGlScott updated this revision to Diff 6513.Jan 31 2016, 9:14 PM
RyanGlScott retitled this revision from to Make TypeError newtype, add changelog entry.
RyanGlScott updated this object.
RyanGlScott edited the test plan for this revision. (Show Details)
RyanGlScott added reviewers: hvr, bgamari, austin.
RyanGlScott updated the Trac tickets for this revision.
RyanGlScott added a subscriber: KaneTW.
RyanGlScott retitled this revision from Make TypeError newtype, add changelog entry to Make TypeError a newtype, add changelog entry.Jan 31 2016, 9:15 PM
RyanGlScott updated this object.
RyanGlScott edited edge metadata.
KaneTW accepted this revision.Feb 1 2016, 5:37 AM
KaneTW added a reviewer: KaneTW.

LGTM

This revision is now accepted and ready to land.Feb 1 2016, 5:37 AM
bgamari requested changes to this revision.Feb 1 2016, 8:57 AM
bgamari edited edge metadata.
bgamari added inline comments.
libraries/base/Control/Exception/Base.hs
369

The only slight concern here is that this break the expectation that Show produces a bit of type-correct Haskell code. That being said, this is far from the first time that such a non-conformant Show instance was provided so I'm okay with keeping it this way.

libraries/base/changelog.md
96

Could you also add an entry to docs/user_guide/8.0.1-notes.rst?

This revision now requires changes to proceed.Feb 1 2016, 8:57 AM
RyanGlScott updated this revision to Diff 6525.Feb 1 2016, 10:10 AM
RyanGlScott edited edge metadata.
  • Update 8.0.1-notes
RyanGlScott marked an inline comment as done.Feb 1 2016, 10:11 AM
RyanGlScott added inline comments.
libraries/base/Control/Exception/Base.hs
369

Indeed, this seems to be the "convention" for exception datatypes' Show instances, for better or worse, so I'm inclined to keep it like this.

bgamari accepted this revision.Feb 1 2016, 3:39 PM
bgamari edited edge metadata.

Looks good to me. Thanks @RyanGlScott!

libraries/base/Control/Exception/Base.hs
369

Indeed.

This revision is now accepted and ready to land.Feb 1 2016, 3:39 PM
This revision was automatically updated to reflect the committed changes.