Restore original alignment for info tables
ClosedPublic

Authored by olsner on Jan 25 2016, 5:44 PM.

Details

Summary

This was broken in 4a32bf925b8aba7885d9c745769fe84a10979a53, meaning that info
tables and subsequent code are no longer guaranteed to have the recommended
alignment.
Split up the section header and section alignment printers, and print an
appropriate alignment directive before each info table.

Fixes Trac Trac #11486

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
olsner updated this revision to Diff 6433.Jan 25 2016, 5:44 PM
olsner retitled this revision from to Restore original alignment for info tables.
olsner updated this object.
olsner edited the test plan for this revision. (Show Details)
olsner added reviewers: austin, rwbarton, bgamari.
olsner updated the Trac tickets for this revision.
olsner added a subscriber: thomie.
bgamari accepted this revision.Jan 26 2016, 2:28 AM
bgamari edited edge metadata.

Looks good. Thanks @olsner!

This revision is now accepted and ready to land.Jan 26 2016, 2:28 AM
rwbarton accepted this revision.Jan 26 2016, 10:29 AM
rwbarton edited edge metadata.

LGTM, and I verified that the output (e.g. ghc-stage2) now has the expected padding before info tables.

This revision was automatically updated to reflect the committed changes.