Enable split sections by default where possible
ClosedPublic

Authored by olsner on Jan 19 2016, 3:14 AM.

Details

Summary

On non-windows platforms with GNU ld, enable SplitSections in the GHC build by
default.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
olsner updated this revision to Diff 6291.Jan 19 2016, 3:14 AM
olsner retitled this revision from to Enable split sections by default where possible.
olsner updated this object.
olsner edited the test plan for this revision. (Show Details)
olsner updated the Trac tickets for this revision.
bgamari requested changes to this revision.Jan 19 2016, 4:16 AM
bgamari edited edge metadata.

What platforms has this been tested on?

mk/config.mk.in
365

Can you reference Trac #11445 here so that future readers can easily find additional commentary?

This revision now requires changes to proceed.Jan 19 2016, 4:16 AM

@olsner, what is the status of this?

olsner added a comment.Dec 1 2016, 4:41 PM

@olsner, what is the status of this?

I was going to make an updated version sometime ages ago but got distracted and forgot all about it :)

olsner updated this revision to Diff 9748.Dec 1 2016, 4:42 PM
olsner edited edge metadata.
  • Fix conflicting defaults with SplitObjs and SplitSections
  • Mention Trac 11445
olsner updated this revision to Diff 9749.Dec 1 2016, 4:44 PM
olsner edited edge metadata.
  • Fix conflicting defaults between SplitObjs and SplitSections
  • Mention Trac 11445
bgamari accepted this revision.Dec 1 2016, 4:51 PM
bgamari edited edge metadata.

Looks good to me. Thanks @olsner!

This revision is now accepted and ready to land.Dec 1 2016, 4:51 PM
DemiMarie added inline comments.
mk/config.mk.in
343

I think we should also disable SplitObjs on Darwin, since Darwin always uses subsections-via-symbols (the -dead_strip linker flag).

This revision was automatically updated to reflect the committed changes.