Add -prelude-is flag
AbandonedPublic

Authored by gibiansky on Aug 22 2014, 1:02 AM.

Details

Reviewers
ezyang
carter
austin
rwbarton
Trac Issues
#9499
Summary

Add the -prelude-is flag to specify the module to use instead of Prelude

Test Plan

Validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
prelude-is-flag
Lint
Lint SkippedExcuse: Linting seems to be broken. Will lint later.
Unit
No Unit Test Coverage
Build Status
Buildable 582
Build 583: GHC Patch Validation (amd64/Linux)
gibiansky updated this revision to Diff 421.Aug 22 2014, 1:02 AM
gibiansky retitled this revision from to Add -prelude-is flag.
gibiansky updated this object.
gibiansky edited the test plan for this revision. (Show Details)
gibiansky added reviewers: austin, carter.
gibiansky updated the Trac tickets for this revision.

Should I added a test for this?

If so, where should that test go? I looked around but couldn't find a good place to put it.

ezyang requested changes to this revision.Aug 22 2014, 7:41 AM
ezyang added a reviewer: ezyang.

testsuite/tests/driver is a pretty normal place for tests

compiler/main/DynFlags.hs
631

This type is wrong, it should just be a ModuleName...

3482

...so that you don't have to invent a fake package key here...

compiler/typecheck/TcRnDriver.lhs
159

...and then ignore it when you read out preludeModIs.

This revision now requires changes to proceed.Aug 22 2014, 7:41 AM

This certainly needs a section in the User's Guide.

How does this interact with all the built-in syntax that is defined in terms of the standard Prelude, such as numeric literals, do notation, list comprehensions, numeric literals in pattern matches, etc.? How does it interact with NoImplicitPrelude or RebindableSyntax?

compiler/main/DynFlags.hs
3485

-prelude-is

rwbarton requested changes to this revision.Sep 16 2014, 12:00 PM
rwbarton added a reviewer: rwbarton.
hvr added a subscriber: hvr.Dec 1 2014, 4:03 AM

What is going on with this? There has been popular demand for this feature in the past and it appears that this diff just needs some documentation (and perhaps some consideration of the issues mentioned by @rwbarton). @gibiansky, are you still up for finishing this?

Check out the GHC trac page. There was more discussion there – it seemed like there were alternatives to this that removed the need for this patch.

Lovely. Would you mind abandoning the Diff in this case? I've been trying to triage some of these idle Diffs.

gibiansky abandoned this revision.Jul 27 2015, 5:25 PM

It is unclear whether this feature is necessary or whether this would be the right way to implement it if it is necessary, so this diff is being abandoned.