Fix panic when using pattern synonyms with DisambiguateRecordFields (#11283)
ClosedPublic

Authored by adamgundry on Dec 24 2015, 5:20 AM.

Details

Summary

This fixes a find_tycon panic when constructing a record pattern synonym
when DisambiguateRecordFields (turned on by RecordWildCards) is enabled.
The handling of record wild cards in such constructions isn't completely
satisfactory, but doing better will require the Parent type to be more
informative, as I'll explain on Trac #11228.

Test Plan

New test patsyn/should_compile/T11283.hs

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
wip/T11283
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7796
Build 9573: GHC Patch Validation (amd64/Linux)
Build 9572: arc lint + arc unit
adamgundry updated this revision to Diff 5967.Dec 24 2015, 5:20 AM
adamgundry retitled this revision from to Fix panic when using pattern synonyms with DisambiguateRecordFields (#11283).
adamgundry updated this object.
adamgundry edited the test plan for this revision. (Show Details)
adamgundry added reviewers: mpickering, austin, bgamari.
adamgundry updated the Trac tickets for this revision.
bgamari requested changes to this revision.Dec 24 2015, 7:48 AM
bgamari edited edge metadata.

@adamgundry, it appears the new test failed.

This revision now requires changes to proceed.Dec 24 2015, 7:48 AM
adamgundry updated this revision to Diff 6019.Dec 29 2015, 3:34 AM
adamgundry edited edge metadata.

Sorry, forgot a file

  • Add missing test result
bgamari accepted this revision.Dec 29 2015, 6:31 AM
bgamari edited edge metadata.

Very good. Thanks @adamgundry!

This revision is now accepted and ready to land.Dec 29 2015, 6:31 AM
This revision was automatically updated to reflect the committed changes.