- fix tests on OpenBSD which requires _DYNAMIC symbol
ClosedPublic

Authored by kgardas on Dec 22 2015, 4:02 PM.

Details

Summary

This patch adds _DYNAMIC symbol to the list of OpenBSD symbols.
The patch fixes unknown _DYNAMIC symbol runtime linker error caused
by recent update of unix library.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kgardas updated this revision to Diff 5943.Dec 22 2015, 4:02 PM
kgardas retitled this revision from to - fix tests on OpenBSD which requires _DYNAMIC symbol.
kgardas updated this object.
kgardas edited the test plan for this revision. (Show Details)
kgardas added reviewers: austin, bgamari.
erikd accepted this revision.Dec 23 2015, 12:13 AM
erikd edited edge metadata.

LTGM.

This revision is now accepted and ready to land.Dec 23 2015, 12:13 AM
This revision was automatically updated to reflect the committed changes.
hvr added a subscriber: hvr.Dec 23 2015, 1:13 AM

do we know which change in unix caused this?

@hvr: I don't know what's exactly culprit. The error looks like:

Compile failed (status 256) errors were:
ghc-stage2: /usr/lib/libpthread.a: unknown symbol `_DYNAMIC'
ghc-stage2: unable to load package `unix-2.7.1.1'

*** unexpected failure for ann01(normal)

so I commented in somewhat foggy way. Anyway, what I know is that few weeks ago those tests were running fine. I've been on 20-30 failures on OpenBSD on GHC HEAD. After a storm of libraries updates I've been again on >200 failures and this _DYNAMIC failure was the culprit. I tried this to fix it and this runs fine. If you require more analysis of this please let me know. My idea here is that unix added some additional call to POSIX threading and this itself requires _DYNAMIC symbol -- but this is just from seeing the failure above...

hvr added a comment.Dec 23 2015, 1:32 AM

Hrm, could be a side-effect of using AC_USE_SYSTEM_EXTENSIONS more consequently...