WIP. Only treat .o and .so files as linker inputs
AbandonedPublic

Authored by thomie on Dec 21 2015, 10:40 AM.

Details

Reviewers
austin
bgamari
Trac Issues
#11247
Summary

The function partition_args partitions all arguments into two sets.
Roughly:

  1. source files
  2. linker inputs

Previously, only the source filename test was explicit, and a file that
didn't look like a source filename but containing a dot would be treated
as a linker input. This could result in confusing error messages (Trac #11247).
Now, we explictly test for object files instead, and treat everything
else as source files.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
devel2
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7700
Build 9437: GHC Patch Validation (amd64/Linux)
Build 9436: arc lint + arc unit
thomie updated this revision to Diff 5905.Dec 21 2015, 10:40 AM
thomie retitled this revision from to WIP. Only treat .o and .so files as linker inputs.
thomie updated this object.
thomie edited the test plan for this revision. (Show Details)
thomie updated the Trac tickets for this revision.
thomie planned changes to this revision.Dec 21 2015, 12:27 PM

This is the wrong approach. Linker inputs can have any extension, for example .dyn_o.

thomie abandoned this revision.Feb 2 2016, 11:27 AM

This is wrong. I only committed the test.