Conditionally show plural "s" in warnings
ClosedPublic

Authored by quchen on Dec 17 2015, 1:37 AM.

Details

Summary

Redundant constraints and defaulting warnings had "constraint(s)" in their
messages; the "s" is now conditional based on the number of things warned
about.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
quchen updated this revision to Diff 5790.Dec 17 2015, 1:37 AM
quchen retitled this revision from to Conditionally show plural "s" in warnings.
quchen updated this object.
quchen edited the test plan for this revision. (Show Details)
quchen added a reviewer: hvr.
quchen updated this revision to Diff 5791.Dec 17 2015, 1:44 AM
quchen edited edge metadata.

Capitalize test

quchen updated this revision to Diff 5794.Dec 17 2015, 3:56 AM
quchen edited edge metadata.

Fix existing tests

quchen updated this object.Dec 17 2015, 3:58 AM
quchen edited edge metadata.
bgamari accepted this revision.Dec 17 2015, 4:12 AM
bgamari edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Dec 17 2015, 4:12 AM
This revision was automatically updated to reflect the committed changes.