Don't group together PatSyns when matching
AbandonedPublic

Authored by mpickering on Dec 15 2015, 2:54 PM.

Details

Reviewers
goldfire
austin
bgamari
Trac Issues
#11224
Summary

It is not always safe, see Trac #11224. We could do quite a bit better
taking some inspiration from view patterns but defaulting to false is
always safe.

Test Plan

./validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
arcpatch-D1622_1
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7461
Build 9074: GHC Patch Validation (amd64/Linux)
Build 9073: arc lint + arc unit
mpickering updated this revision to Diff 5734.Dec 15 2015, 2:54 PM
mpickering retitled this revision from to Don't group together PatSyns when matching.
mpickering updated this object.
mpickering edited the test plan for this revision. (Show Details)
mpickering added a reviewer: goldfire.
mpickering updated the Trac tickets for this revision.
bgamari accepted this revision.Dec 15 2015, 3:04 PM
bgamari edited edge metadata.

Alright. Perhaps you could open a ticket to make sure we don't lose track of this potential optimization?

This revision is now accepted and ready to land.Dec 15 2015, 3:04 PM

No idea why validate is failing.

Simon has a better fix for this on his branch where he is working on 11224.

mpickering abandoned this revision.Dec 21 2015, 5:32 PM