Fix infix record field fixity (#11167).
AbandonedPublic

Authored by KaneTW on Dec 7 2015, 11:01 AM.

Details

Reviewers
austin
bgamari
Trac Issues
#11167
Summary

Note that the ambiguous case is untested, as infix declarations for record fields are broken. Furthermore, this might not even be an issue without the rest of OverloadedRecordFields.

Diff Detail

KaneTW updated this revision to Diff 5535.Dec 7 2015, 11:01 AM
KaneTW retitled this revision from to Fix infix record field fixity (#11167)..
KaneTW updated this object.
KaneTW edited the test plan for this revision. (Show Details)
KaneTW updated the Trac tickets for this revision.
KaneTW updated this revision to Diff 5537.Dec 7 2015, 11:10 AM
KaneTW edited edge metadata.

Add same-fixity ambiguous test case

hvr added a subscriber: hvr.Dec 7 2015, 11:47 AM
hvr added inline comments.
testsuite/tests/rename/should_compile/T11167.hs
14

you may want to clarify that comment... as the type-error is not desired :-)

KaneTW updated this revision to Diff 5539.Dec 7 2015, 12:01 PM
KaneTW edited edge metadata.

Clarify T11167.hs test case

KaneTW marked an inline comment as done.Dec 7 2015, 12:01 PM

Thanks for sorting this out, looks good to me. We want DuplicateRecordFields to be usable in isolation, so it is worth doing. I'll see if I can correct infix declarations for record fields and test the ambiguous case more thoroughly.

I've created a new revision (D1600) incorporating these changes (apologies if this was the Wrong Thing to do on Phab...) that fixes up the remaining problems with infix fields.

bgamari edited edge metadata.Dec 11 2015, 11:04 AM

@KaneTW, it sounds like this has been superceded by D1600; perhaps you could abandon this Diff?

KaneTW abandoned this revision.Dec 11 2015, 11:06 AM

Superseded by D1600