...if you could add a libraries/base/changelog.md entry... that'd be great! :-)
AutoDeriveTypeable is redundant
maintainer needs to change
@since 184.108.40.206 annotations missing
since when were these deprecated?
@ekmett do we really want to bring in deprecated items into base?
we need to get this one merged upstream before we can land this in ghc (see comment in D1544)
What about items (2) and (3) from the original proposal?
For (2), introducing Data.Functor.Const seems especially pertinent now that Constant in transformers is poly-kinded, but Const in base isn't. :( If we migrate Const to Data.Functor.Const and turn on PolyKinds, that would also knock out Trac #10039.
For (3), make sure the newly introduced data types have derived Data, Generic, and Generic1 instances.
I would like to see this get done, but given how small the remaining window is for 8.0, we might have to push this back to 8.2. In addition to the normal delays associated with a module migration like this, I also have some reservations about the new Data.Functor.Classes that I would like to be addressed before going forward with this.
Alright, transformers has been updated to conditionally expose Data.Functor.Classes et al. @hvr, can you update the GHC transformers mirror?
Once that's done, we can close D1544 and get moving and the remaining changes for this Diff. (Note that adding Data.Functor.Const is now out of the scope of this Diff, since that is covered in D1630.)
Thanks to you all!
(I manually uploaded a git diff since checking out the patch failed horribly for some reason).
Yes... differentials uploaded manually are a big mess currently... and require special care :-/
Anyway, I hope Harbormaster won't complain about what I just pushed...