Add linter to check for binaries accidentally added to repository
ClosedPublic

Authored by bgamari on Nov 23 2015, 8:35 AM.

Details

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bgamari updated this revision to Diff 5267.Nov 23 2015, 8:35 AM
bgamari retitled this revision from to Add linter to check for binaries accidentally added to repository.
bgamari updated this object.
bgamari edited the test plan for this revision. (Show Details)
bgamari added reviewers: austin, thomie, hvr.
hvr edited edge metadata.Nov 23 2015, 8:48 AM

...does this actually work? :-)

hvr awarded a token.Nov 23 2015, 8:48 AM

@hvr, it did locally. Do you see any reason why it shouldn't?

hvr added a comment.Nov 23 2015, 8:54 AM

@hvr, it did locally. Do you see any reason why it shouldn't?

nope... I just thought you had problems yesterday

austin requested changes to this revision.Nov 24 2015, 9:52 AM
austin edited edge metadata.

You know me... I'm somewhat loathe to add submodules where they don't need to exist normally. Is there any reason we can't just make GHC have the authoritative copy of arcanist-external-json-linter under utils/arc or something? I wanted to mention this before you wrote the diff but I didn't get a chance...

This revision now requires changes to proceed.Nov 24 2015, 9:52 AM
austin accepted this revision.Nov 24 2015, 9:56 AM
austin edited edge metadata.

On second thought, this structure is fine, since presumably the external JSON linter won't change much... But we should maybe put the submodule on git.haskell.org, too...

This revision is now accepted and ready to land.Nov 24 2015, 9:56 AM
This revision was automatically updated to reflect the committed changes.