Fix interaction of DuplicateRecordFields and GHC.Generics
ClosedPublic

Authored by adamgundry on Nov 17 2015, 10:14 AM.

Details

Summary

This prevents GHC.Generics from exposing mangled selector names
when used on a datatype defined with DuplicateRecordFields enabled.

Test Plan

New test overloadedrecflds_generics, which tests that both
GHC.Generics and Data.Data use the correct field labels, not mangled names.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamgundry retitled this revision from to Fix interaction of DuplicateRecordFields and GHC.Generics.Nov 17 2015, 10:14 AM
adamgundry updated this object.
adamgundry edited the test plan for this revision. (Show Details)
bgamari accepted this revision.Nov 19 2015, 4:57 AM

Looks reasonable to me.

This revision is now accepted and ready to land.Nov 19 2015, 4:57 AM
This revision was automatically updated to reflect the committed changes.