Eliminate some code duplication in x86 backend (genCCall32/64)
ClosedPublic

Authored by rwbarton on Aug 10 2014, 3:43 PM.

Details

Summary

No functional changes except in panic messages.

These functions were identical except for

  • x87 operations in genCCall32
  • the fallback to genCCall32'/64'
  • "32" vs "64" in panic messages (one case was wrong!)
  • minor syntactic or otherwise non-functional differences.
Test Plan

Ran "validate --no-dph --slow" before and after the change.
Only differences were two tests that failed before the change but not after,
further investigation revealed that those tests are in fact erratic.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Lint Skipped
Unit
Unit Tests Skipped
rwbarton updated this revision to Diff 309.Aug 10 2014, 3:43 PM
rwbarton retitled this revision from to Eliminate some code duplication in x86 backend (genCCall32/64).
rwbarton updated this object.
rwbarton edited the test plan for this revision. (Show Details)
rwbarton added a reviewer: simonmar.
austin accepted this revision.Aug 10 2014, 3:57 PM
austin edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Aug 10 2014, 3:57 PM

Whoops, Build B376: Diff 309 (D139) has failed! Full logs available at F12334.

rwbarton closed this revision.Aug 10 2014, 4:38 PM
rwbarton updated this revision to Diff 314.

Closed by commit rGHCc80d238162d9 (authored by @rwbarton).