Parser: revert parser error messages to what they were before 7.10
ClosedPublic

Authored by thomie on Oct 4 2015, 12:05 PM.

Details

Summary

Among doing other things, Phab:D201
(bc2289e13d9586be087bd8136943dc35a0130c88) tried to improve the error
messages thrown by the parser. For example a missing else clause now
prints "parse error in if statement: else clause empty" instead of
"parse error (possibly incorrect indentation or mismatched brackets)".

Some error messages got much worse however (see tests), and the result
seems to be a net negative. Although not entirely satisfactory, this
commits therefore reverts those parser changes.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thomie updated this revision to Diff 4423.Oct 4 2015, 12:05 PM
thomie retitled this revision from to Parser: revert parser error messages to what they were before 7.10.
thomie updated this object.
thomie edited the test plan for this revision. (Show Details)
thomie added a reviewer: mikeizbicki.
thomie updated the Trac tickets for this revision.
austin accepted this revision.Oct 5 2015, 12:47 PM
austin edited edge metadata.

Yeah, I think you're right in retrospect; I guess I missed a few of these during review - sorry!

Is there a bug we can track this in the mean time? I mean for the original change; we should probably discuss such changes a bit more and try to double back on them later...

This revision is now accepted and ready to land.Oct 5 2015, 12:47 PM
This revision was automatically updated to reflect the committed changes.