Fix #10600 by desugaring when exhaustiveness warnings are requested.
Needs RevisionPublic

Authored by ezyang on Sep 24 2015, 1:59 PM.

Details

Reviewers
bgamari
austin
Trac Issues
#10600
Summary

Unfortunately, this patch doesn't validate due to a lint error when
running Haddock on the fake "documentation" module for GHC.Prim.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Test Plan

validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
ghc-validate
Lint
Lint WarningsExcuse: lint
SeverityLocationCodeMessage
Warningcompiler/main/DriverPipeline.hs:255TXT3Line Too Long
Warningcompiler/main/DriverPipeline.hs:258TXT3Line Too Long
Warningcompiler/main/HscMain.hs:687TXT3Line Too Long
Unit
No Unit Test Coverage
Build Status
Buildable 5807
Build 6396: GHC Patch Validation (amd64/Linux)
Build 6395: arc lint + arc unit
ezyang updated this revision to Diff 4314.Sep 24 2015, 1:59 PM
ezyang retitled this revision from to Fix #10600 by desugaring when exhaustiveness warnings are requested..
ezyang edited the test plan for this revision. (Show Details)
ezyang updated the Trac tickets for this revision.
ezyang updated this object.

The following warning flags should also go into the needsDesugar list I think:

Opt_WarnInlineRuleShadowing
Opt_WarnOverlappingPatterns
Opt_WarnUnusedDoBind
Opt_WarnWrongDoBind

Found by running:

grep -R -o -h 'Opt_Warn[^ ]*' compiler/deSugar/ | sort | uniq
ezyang updated this revision to Diff 4315.Sep 24 2015, 2:33 PM
ezyang edited edge metadata.

add more flags

bgamari requested changes to this revision.Sep 27 2015, 4:22 AM
bgamari edited edge metadata.

The idea here seems pretty reasonable but we do need to figure out what to do with GHC.Prim. Bumping out of review queue while we figure this out.

This revision now requires changes to proceed.Sep 27 2015, 4:22 AM

We discussed this in this week's GHC call. There were few conclusions sadly but I've left some nots on Trac #10600.

austin resigned from this revision.Nov 6 2017, 10:11 PM