Update Cabal to recognize DeriveLift (#1830)
ClosedPublic

Authored by RyanGlScott on Sep 22 2015, 10:13 AM.

Details

Summary

This should (1) fix the ./validate build, which I accidentally broke
in D1168, and (2) update the Cabal submodule so that it recognizes DeriveLift
as a GHC extension.

Test Plan

./validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
RyanGlScott retitled this revision from to Update Cabal to recognize DeriveLift (#1830).
RyanGlScott updated this object.
RyanGlScott edited the test plan for this revision. (Show Details)
RyanGlScott updated the Trac tickets for this revision.
adamse edited edge metadata.Sep 22 2015, 11:10 AM

Both failing test-cases (https://phabricator.haskell.org/harbormaster/build/6301/) seem to be related to Cabal in some way...

adamse requested changes to this revision.EditedSep 22 2015, 11:16 AM
adamse edited edge metadata.

Also this line still appears

*** framework failure for T1830(duplicate) There are multiple tests with this name

Edit: perhaps this should be two diffs, one updating Cabal (with corresponding fixes) and one fixing the "framework" failure.

This revision now requires changes to proceed.Sep 22 2015, 11:16 AM
RyanGlScott updated this revision to Diff 4291.Sep 23 2015, 8:55 AM
RyanGlScott edited edge metadata.
  • Fix test suites impacted by Cabal changes

Thanks for helping me diagnose the issues, Adam. And thanks to Austin for cleaning up the unintentional mess I created :\

I rebased and fixed the test suites which were impacted by that Cabal commit—everything appears to work now.

adamse accepted this revision.Sep 23 2015, 9:59 AM
adamse edited edge metadata.

You're welcome. It was nice to be able to help!

This revision is now accepted and ready to land.Sep 23 2015, 9:59 AM
austin accepted this revision.Sep 23 2015, 10:27 AM
austin edited edge metadata.

Thanks Ryan!

This revision was automatically updated to reflect the committed changes.