Export more types from GHC.RTS.Flags (#9970)
ClosedPublic

Authored by RyanGlScott on Jul 2 2015, 4:27 PM.

Details

Summary

Export the data types GiveGCStats, DoCostCentres, DoHeapProfiles,
and DoTrace, as well as the type synonyms Time and RtsNat. The
above data types appear as fields in the -Stats data types in
GHC.RTS.Flags, but since they only have Show instances, it is
practically impossible to due anything useful with the above types
unless they are exported.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
RyanGlScott updated this revision to Diff 3377.Jul 2 2015, 4:27 PM
RyanGlScott retitled this revision from to Export more types from GHC.RTS.Flags (#9970).
RyanGlScott updated this object.
RyanGlScott edited the test plan for this revision. (Show Details)
RyanGlScott added reviewers: hvr, ekmett.
RyanGlScott updated the Trac tickets for this revision.
ezyang requested changes to this revision.Jul 4 2015, 1:07 AM
ezyang edited edge metadata.

Time is a bit unfortunate of a type synonym to export (I suspect I defined it as a sort of internal measure, not intending it to be used by external clients), but the rest looks fine. Maybe we should rename Time?

This revision now requires changes to proceed.Jul 4 2015, 1:07 AM

Hm. At the risk of inducing RAS syndrome, we could rename it to something like RtsTime.

bgamari requested changes to this revision.Jul 7 2015, 5:01 AM
bgamari added a reviewer: bgamari.

RtsTime sounds good to me.

RyanGlScott updated this revision to Diff 3455.Jul 7 2015, 9:31 AM
RyanGlScott edited edge metadata.
  • Rename Time to RtsTime
bgamari accepted this revision.Jul 7 2015, 9:46 AM
bgamari edited edge metadata.

Looks good to me.

This revision was automatically updated to reflect the committed changes.